rdblue commented on a change in pull request #2985:
URL: https://github.com/apache/iceberg/pull/2985#discussion_r711801632
##########
File path: core/src/test/java/org/apache/iceberg/TableTestBase.java
##########
@@ -433,6 +434,26 @@ void validateDeleteManifest(ManifestFile manifest,
Assert.assertFalse("Should find all files in the manifest",
expectedFiles.hasNext());
}
+ protected DataFile newDataFile(String partitionPath) {
+ return DataFiles.builder(table.spec())
+ .withPath("/path/to/data-" + UUID.randomUUID() + ".parquet")
+ .withFileSizeInBytes(10)
+ .withPartitionPath(partitionPath)
+ .withRecordCount(1)
+ .build();
+ }
+
+ protected DeleteFile newDeleteFile(int specId, String partitionPath) {
+ PartitionSpec spec = table.specs().get(specId);
+ return FileMetadata.deleteFileBuilder(spec)
+ .ofPositionDeletes()
+ .withPath("/path/to/delete" + UUID.randomUUID() + ".parquet")
Review comment:
Nit: should be `delete-` to match `data-`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
