rdblue commented on a change in pull request #3069:
URL: https://github.com/apache/iceberg/pull/3069#discussion_r711803984
##########
File path: core/src/main/java/org/apache/iceberg/BaseRewriteFiles.java
##########
@@ -101,7 +101,7 @@ public RewriteFiles validateFromSnapshot(long snapshotId) {
protected void validate(TableMetadata base) {
if (replacedDataFiles.size() > 0) {
// if there are replaced data files, there cannot be any new row-level
deletes for those data files
- validateNoNewDeletesForDataFiles(base, startingSnapshotId,
replacedDataFiles);
+ validateNoNewDeletesForDataFiles(base, startingSnapshotId, null,
replacedDataFiles, true);
Review comment:
It would be nice to have an overload with the original args, since it
isn't obvious what `true` is doing here. It's an internal API, but an overload
still makes this more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
