RussellSpitzer commented on a change in pull request #3126:
URL: https://github.com/apache/iceberg/pull/3126#discussion_r712399335
##########
File path:
spark3/src/test/java/org/apache/iceberg/actions/TestRemoveOrphanFilesAction3.java
##########
@@ -134,6 +135,24 @@ public void testSparkSessionCatalogHadoopTable() throws
Exception {
results.contains("file:" + location + "/data/trashfile"));
}
+ @Test
+ public void testSparkSessionCatalogHiveWrongConfig() {
+ spark.conf().set("spark.sql.catalog.spark_catalog",
"org.apache.iceberg.spark.SparkSessionCatalog");
+ spark.conf().set("spark.sql.catalog.spark_catalog.type", "hive");
+ spark.conf().set("spark.sql.catalog.spark_catalog.uri",
"thrift://localhost:9083");
+ if (spark.version().equalsIgnoreCase("3.0.3")) {
Review comment:
Not sure I understand the Class Cast here,
Also we have some Spark3VersionUtil classes you may want to use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
