rdblue commented on a change in pull request #3023:
URL: https://github.com/apache/iceberg/pull/3023#discussion_r712400321
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java
##########
@@ -35,22 +36,22 @@
private final boolean isDictionaryEncoded;
private final Dictionary dictionary;
private final NullabilityHolder nullabilityHolder;
- private final Type icebergType;
+ private final Types.NestedField icebergField;
public VectorHolder(
ColumnDescriptor columnDescriptor, FieldVector vector, boolean
isDictionaryEncoded,
- Dictionary dictionary, NullabilityHolder holder, Type type) {
+ Dictionary dictionary, NullabilityHolder holder, Types.NestedField
icebergField) {
Review comment:
Do we consider this an API that we need to maintain compatibility with?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
