wypoon commented on pull request #1508: URL: https://github.com/apache/iceberg/pull/1508#issuecomment-925194146
@rdblue, when you have the time, this is ready for another review. I believe I have incorporated all your feedback. I have incorporated your proposed change (after some refactoring) to the spark `Reader` to configure a base `TableScan` on construction, and let the `TableScan` get the schema for the snapshot; as well as the other suggestions. I also fixed a bug with my last change to `BaseTableScan#useSnapshot`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
