kbendick commented on a change in pull request #3078:
URL: https://github.com/apache/iceberg/pull/3078#discussion_r715232319



##########
File path: core/src/main/java/org/apache/iceberg/util/PropertyUtil.java
##########
@@ -70,4 +71,16 @@ public static String propertyAsString(Map<String, String> 
properties,
     }
     return defaultValue;
   }
+
+  public static Properties filterAndRemovePrefix(Map<String, String> 
properties,

Review comment:
       I would agree with Jack that until we actually go to reuse this code, it 
might be best to place it in `JdbcUtil` for now @dungdm93.
   
   Possibly as a follow up PR we could move it to be more generic and also 
update the various places that have similar functionality at the same time.
   
   But for now, I think it's probably best to keep it in `JdbcUtil` so we can 
get this PR in to fix this bug. 🙂 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to