openinx commented on a change in pull request #2935:
URL: https://github.com/apache/iceberg/pull/2935#discussion_r715379381
##########
File path: orc/src/main/java/org/apache/iceberg/data/orc/GenericOrcWriters.java
##########
@@ -531,6 +543,32 @@ public void nonNullWrite(int rowId, Map<K, V> map,
ColumnVector output) {
}
}
+ private static class PositionDeleteWriter implements
OrcRowWriter<PositionDelete<Record>> {
Review comment:
The unit tests you provided is built on top of the `GenericRecord`, so
we could not find the above issue. But when we try to integrate the
PositionDeleteWriter into flink or spark, the above issue will happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
