openinx commented on a change in pull request #3067:
URL: https://github.com/apache/iceberg/pull/3067#discussion_r715421981
##########
File path: build.gradle
##########
@@ -262,6 +262,36 @@ project(':iceberg-data') {
}
}
+project(':iceberg-aliyun') {
+ dependencies {
+ compile project(':iceberg-api')
+ compile project(':iceberg-common')
+
+ compileOnly 'com.aliyun.oss:aliyun-sdk-oss'
+ compileOnly 'javax.xml.bind:jaxb-api'
+ compileOnly 'javax.activation:activation'
+ compileOnly 'org.glassfish.jaxb:jaxb-runtime'
Review comment:
Okay, then I will recommend to package all the dependencies jar into a
single bundled iceberg-aliyun jar. Because in flink SQL client, we will need
to add [each
jar](https://iceberg.apache.org/flink/#preparation-when-using-flink-sql-client)
in the shell as the following:
```shell
./bin/sql-client.sh embedded \
-j <iceberg-aliyu>.jar \
-j <aliyun-oss>.jar \
-j <javax.xml.bind:jaxb-api>.jar \
-j <org.glassfish.jaxb:jaxb-runtime>.jar
shell
```
It will be quite tedious for people to add jars one by one to make the
iceberg job works ( aws-sdk don't need to package all of them into a bundled
jar because aws sdk has provided
[it](https://mvnrepository.com/artifact/software.amazon.awssdk/bundle) ( see
[document](https://iceberg.apache.org/aws/#enabling-aws-integration)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
