jackye1995 commented on a change in pull request #3175:
URL: https://github.com/apache/iceberg/pull/3175#discussion_r715761064
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java
##########
@@ -175,8 +175,15 @@ private void newStream() throws IOException {
stream.close();
}
+ boolean createStagingDirectory = false;
+ if (!stagingDirectory.exists()) {
+ createStagingDirectory = stagingDirectory.mkdirs();
Review comment:
based on the documentation, this can also throw `SecurityException` that
needs to be handled. We should also add some logging if staging directory is
created, and if creation failed for some reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
