aokolnychyi commented on a change in pull request #3176: URL: https://github.com/apache/iceberg/pull/3176#discussion_r715884386
########## File path: core/src/main/java/org/apache/iceberg/io/PositionDeltaWriter.java ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.io; + +import java.io.Closeable; +import org.apache.iceberg.DataFile; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.PartitionSpec; +import org.apache.iceberg.StructLike; + +/** + * A writer capable of writing data and position deletes that may belong to different specs and partitions. + * + * @param <T> the row type + */ +public interface PositionDeltaWriter<T> extends Closeable { + + /** + * Inserts a row to the provided spec/partition. + * + * @param row a data record + * @param spec a partition spec + * @param partition a partition or null if the spec is unpartitioned + */ + void insert(T row, PartitionSpec spec, StructLike partition); + + /** + * Deletes a position in the provided spec/partition without persisting the old row. Review comment: The spec allows us to persist the deleted row in positional delete files. This may be helpful to reconstruct CDC records or to persist the sort key for min/max filtering. That being said, I don't plan to persist it from Spark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
