RussellSpitzer commented on a change in pull request #2942:
URL: https://github.com/apache/iceberg/pull/2942#discussion_r715922843



##########
File path: data/src/main/java/org/apache/iceberg/data/BaseWriterFactory.java
##########
@@ -220,6 +219,7 @@ protected BaseWriterFactory(Table table, FileFormat 
dataFileFormat, Schema dataS
         case PARQUET:
           Parquet.DeleteWriteBuilder parquetBuilder = 
Parquet.writeDeletes(outputFile)
               .setAll(properties)
+              .metricsConfig(metricsConfig)

Review comment:
       nit: Should we leave a todo in the ORC path?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to