openinx commented on pull request #3116: URL: https://github.com/apache/iceberg/pull/3116#issuecomment-927232962
> In order to be compatible with Flink 1.12 and 1.13, this commit only implements `TableFactory` interface. By 'compatible', I mean the code can be compiled with both 1.12 and 1.13 and pass all unit tests in iceberg-flink module. > I have tried to make iceberg to use different META-INF file based on Flink version, but this still does not work cause the [`createCatalog(Context context)` method in `Factory`](https://github.com/apache/flink/blob/5f007ff6c8224c6e5a14de2c79296eb85a22fe1f/flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/CatalogFactory.java#L61). The `Context` object is new in 1.13. Are there any feasible way that we can compile iceberg depended on 1.12 without this class? > @kbendick @openinx Is the deprecated [createCatalog](https://github.com/apache/flink/blob/5f007ff6c8224c6e5a14de2c79296eb85a22fe1f/flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/CatalogFactory.java#L51) work for both flink 1.12 & flink 1.13 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
