stevenzwu commented on a change in pull request #3181:
URL: https://github.com/apache/iceberg/pull/3181#discussion_r716271081
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java
##########
@@ -46,7 +46,7 @@
class ParquetWriter<T> implements FileAppender<T>, Closeable {
- private static DynConstructors.Ctor<PageWriteStore> pageStoreCtorParquet =
DynConstructors
+ private static final DynConstructors.Ctor<PageWriteStore>
pageStoreCtorParquet = DynConstructors
Review comment:
In this PR, I also fixed this compiler warnings and `RuntimeIOException`
deprecation (to `UncheckedIOException`). Please let me know if it is preferred
to leave those out as a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
