zhangminglei commented on a change in pull request #3186:
URL: https://github.com/apache/iceberg/pull/3186#discussion_r716696946



##########
File path: 
spark/src/main/java/org/apache/iceberg/spark/source/BatchDataReader.java
##########
@@ -59,6 +66,80 @@
     this.batchSize = size;
   }
 
+  protected Map<Integer, ?> findMoreCompoundConstants(Schema tableSchema, 
Map<Integer, ?> idToConstant) {
+    Map<Integer, Object> compoundTypeConstants = new HashMap<>();
+    List<Types.NestedField> columns = tableSchema.columns();
+
+    for (Types.NestedField nestedField: columns) {
+      compoundTypeConstants = visitCompoundTypesByDFS(nestedField, 
idToConstant);
+    }
+    compoundTypeConstants.putAll(idToConstant);
+    return compoundTypeConstants;
+  }
+
+  protected boolean containsCompoundType(Schema tableSchema) {

Review comment:
       you are right. i add this for a easy way to view. will remove this soon.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to