aokolnychyi commented on a change in pull request #2984:
URL: https://github.com/apache/iceberg/pull/2984#discussion_r716870512
##########
File path:
spark3/src/test/java/org/apache/iceberg/spark/source/TestSparkCatalog.java
##########
@@ -31,7 +30,14 @@
@Override
public Table loadTable(Identifier ident) throws NoSuchTableException {
- TestTables.TestTable table =
TestTables.load(Spark3Util.identifierToTableIdentifier(ident).toString());
- return new SparkTable(table, false);
+ String[] parts = ident.name().split("\\$", 2);
+ if (parts.length == 2) {
+ TestTables.TestTable table = TestTables.load(parts[0]);
+ String[] metadataColumns = parts[1].split(",");
+ return new SparkTestTable(table, metadataColumns, false);
Review comment:
I wanted to simply overload `newScanBuilder` in `SparkTestTable` but it
did not work. We can get rid of this once we migrate to Spark 3.2 so I don't
worry too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
