jackye1995 commented on a change in pull request #3175:
URL: https://github.com/apache/iceberg/pull/3175#discussion_r717275514
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java
##########
@@ -170,11 +171,12 @@ public void write(byte[] b, int off, int len) throws
IOException {
}
}
- private void newStream() throws IOException {
+ private void newStream() throws IOException, SecurityException {
Review comment:
Sorry for the back and forth, I read the documentation for mkdirs, it
seems like SecurityException only catches JVM level permission and it might
still just return false for OS level permission failure, so it's hard to have a
consistent behavior for error handling. Because of that, plus the fact that
SecurityException is a runtime exception, I think we can remove the special
handling of it and just let it throw to the top level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
