openinx commented on a change in pull request #3197: URL: https://github.com/apache/iceberg/pull/3197#discussion_r718106479
########## File path: aliyun/src/test/java/org/apache/iceberg/aliyun/oss/AliyunOSSTestUtility.java ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.aliyun.oss; + +import org.apache.iceberg.aliyun.oss.mock.AliyunOSSMockRule; +import org.apache.iceberg.common.DynConstructors; +import org.apache.iceberg.relocated.com.google.common.base.Strings; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class AliyunOSSTestUtility { + private static final Logger LOG = LoggerFactory.getLogger(AliyunOSSTestUtility.class); + private static final String ALIYUN_OSS_TEST_RULE_CLASS = "ALIYUN_OSS_TEST_RULE_CLASS"; + + private AliyunOSSTestUtility() { + } + + public static AliyunOSSTestRule initialize() { + String implClass = System.getenv(ALIYUN_OSS_TEST_RULE_CLASS); + AliyunOSSTestRule testRule; + + if (!Strings.isNullOrEmpty(implClass)) { + DynConstructors.Ctor<AliyunOSSTestRule> ctor; Review comment: Nit: Looks like this line don't have to be a separate one, I think it can be moved to the line 43 because I don't see other place are referencing it except the `try{}` block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
