RussellSpitzer commented on a change in pull request #3199:
URL: https://github.com/apache/iceberg/pull/3199#discussion_r718527924
##########
File path: api/src/main/java/org/apache/iceberg/OverwriteFiles.java
##########
@@ -107,23 +107,29 @@
OverwriteFiles caseSensitive(boolean caseSensitive);
/**
- * Enables validation that files added concurrently do not conflict with
this commit's operation.
+ * Enables validation that data files added concurrently do not conflict
with this commit's operation.
* <p>
- * This method should be called when the table is queried to determine which
files to delete/append.
+ * This method should be called while committing non-idempotent overwrite
operations.
* If a concurrent operation commits a new file after the data was read and
that file might
* contain rows matching the specified conflict detection filter, the
overwrite operation
* will detect this during retries and fail.
* <p>
* Calling this method with a correct conflict detection filter is required
to maintain
- * serializable isolation for eager update/delete operations. Otherwise, the
isolation level
+ * serializable isolation for overwrite operations. Otherwise, the isolation
level
* will be snapshot isolation.
* <p>
* Validation applies to files added to the table since the snapshot passed
to {@link #validateFromSnapshot(long)}.
*
* @param conflictDetectionFilter an expression on rows in the table
* @return this for method chaining
+ * @deprecated since 0.13.0, will be removed in 0.14.0; use {@link
#conflictDetectionFilter(Expression)} and
+ * {@link #validateNoConflictingDataFiles()} instead.
*/
- OverwriteFiles validateNoConflictingAppends(Expression
conflictDetectionFilter);
+ @Deprecated
+ default OverwriteFiles validateNoConflictingAppends(Expression
conflictDetectionFilter) {
+ conflictDetectionFilter(conflictDetectionFilter);
Review comment:
Shouldn't we be using this return value with
validateNoConflictingAppends?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
