RussellSpitzer commented on a change in pull request #2921:
URL: https://github.com/apache/iceberg/pull/2921#discussion_r718794871
##########
File path:
spark3/src/main/java/org/apache/iceberg/spark/procedures/ExpireSnapshotsProcedure.java
##########
@@ -79,6 +85,7 @@ public StructType outputType() {
Identifier tableIdent = toIdentifier(args.getString(0),
PARAMETERS[0].name());
Long olderThanMillis = args.isNullAt(1) ? null :
DateTimeUtil.microsToMillis(args.getLong(1));
Integer retainLastNum = args.isNullAt(2) ? null : args.getInt(2);
+ Integer maxConcurrentDeletes = args.isNullAt(3) ? null : args.getInt(3);
Review comment:
I think the only thing left is we should check that maxCurrentDeletes is
null or > 0, after that I think we are good to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
