rdblue commented on a change in pull request #3199:
URL: https://github.com/apache/iceberg/pull/3199#discussion_r718945090
##########
File path: core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java
##########
@@ -127,8 +147,29 @@ protected void validate(TableMetadata base) {
}
}
- if (conflictDetectionFilter != null && base.currentSnapshot() != null) {
- validateAddedDataFiles(base, startingSnapshotId,
conflictDetectionFilter, caseSensitive);
+
+ if (validateNewDataFiles && base.currentSnapshot() != null) {
+ validateAddedDataFiles(base, startingSnapshotId,
conflictDetectionFilter(), caseSensitive);
+ }
+
+ if (validateNewDeleteFiles && base.currentSnapshot() != null) {
+ if (rowFilter() != Expressions.alwaysFalse()) {
+ validateNoNewDeleteFiles(base, startingSnapshotId,
conflictDetectionFilter(), caseSensitive);
+ } else if (deletedDataFiles.size() > 0) {
Review comment:
When would a user want to make that distinction? I think that it comes
down to knowing how the underlying check is implemented, but we don't want
users making different calls because they want the underlying system to
optimize itself. That seems like it will get users into correctness trouble.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
