samredai commented on a change in pull request #3184: URL: https://github.com/apache/iceberg/pull/3184#discussion_r717975921
########## File path: python/src/iceberg/catalog/__init__.py ########## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. Review comment: > I thought we were planning on flattening the structure instead of having package here? I think a flat structure makes the usage look cleaner (i.e. `from iceberg import Catalog` instead of `from iceberg.catalog import Catalog`). On the flip side, developing for the library feels more manageable when everything is grouped into single-responsibility packages. I think we can get the best of both worlds by organizing the directory/package structure to optimize for the latter, and then defining an `__all__` array in the root `__init__.py` that bubbles up everything the user needs to a flat API at the top-level. How does that sound? ########## File path: python/src/iceberg/catalog/__init__.py ########## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. Review comment: > I thought we were planning on flattening the structure instead of having package here? I think a flat structure makes the usage look cleaner (i.e. `from iceberg import Catalog` instead of `from iceberg.catalog import Catalog`). On the flip side, developing for the library feels more manageable when everything is grouped into single-responsibility packages. I think we can get the best of both worlds by organizing the directory/package structure to optimize for the latter, and then defining an `__all__` array in the root `__init__.py` that bubbles up everything the user needs to a flat API at the top-level. How does that sound? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
