nssalian commented on pull request #3177: URL: https://github.com/apache/iceberg/pull/3177#issuecomment-930653744
Some observations from looking at the POC and the current JdbcCatalog. Caveat: I'm new to Iceberg, so apologies if I missed something in this. Overall: 1. @miR172 is using jooq to generate the sql objects vs java.sql for the sql operations on the JdbcCatalog. 2. To avoid a double implementation and refactor, we should combine the differences of the POC and the current catalog to make sure we can capture the features missing in the current. Feature changes: 1. Tables in the current catalog could definitely improve with timestamp fields. Adding more timestamp and possible ownership fields can help. 2. Schemas of the Table and Namespace can be clearer. 3. Namespace properties has methods but unsupported in the current. I propose creating a `JdbcNamespaceOperations` to allow more flexibility of methods for namespaces. We can have a more deliberate schema (fields supported for namespace). @rdblue , @jackye1995 how can I help here? Shall we open a different issue to help incorporate changes? If there are changes I missed, please correct me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
