xingbowu commented on pull request #3200:
URL: https://github.com/apache/iceberg/pull/3200#issuecomment-930694534


   Thanks @jackye1995 for taking attention on this problem. 
   Yes, In current build, it doesn't check this rule no matter 0~2 or sth else. 
I am not sure which process should check it.
   
   Regarding to the correct configuration, Whether 
BLANK_LINES_AROUND_METHOD_IN_INTERFACE as 0 is per original purpose or not?I am 
not sure who the owner of codesytle is?  also involve @rdblue @openinx to give 
more suggestions.
   
   IMO, A single blank line around method in interface, it is more readability.
   I checked existed code, most of them followed up this rule with single blank 
line
   
![image](https://user-images.githubusercontent.com/12458911/135374517-cfe4222d-cc1b-497e-92e2-20e20b4f717c.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to