aokolnychyi commented on a change in pull request #3199:
URL: https://github.com/apache/iceberg/pull/3199#discussion_r720372108
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java
##########
@@ -372,7 +372,9 @@ private void commitWithSerializableIsolation(OverwriteFiles
overwriteFiles,
}
Expression conflictDetectionFilter = conflictDetectionFilter();
- overwriteFiles.validateNoConflictingAppends(conflictDetectionFilter);
+ overwriteFiles.conflictDetectionFilter(conflictDetectionFilter);
+ overwriteFiles.validateNoConflictingData();
+ overwriteFiles.validateNoConflictingDeletes();
Review comment:
I think that can only be done for merge-on-read. If I delete file_A with
copy-on-write and overwrite it with file_B, I should still check no deletes
happened for file_A, otherwise I'll undelete records.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
