jun-he commented on a change in pull request #3184: URL: https://github.com/apache/iceberg/pull/3184#discussion_r720740590
########## File path: python/src/iceberg/catalog/__init__.py ########## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. Review comment: I am thinking if we keep the package and keep different catalog implementations within it, then users can use ``` from iceberg.catalog import hive from iceberg.catalog import glue ... ``` So all table spec core classes are in the top level and then we put pluggable classes to the packages, `catalog`, `io`. Additionally, we can define them in `__init__.py` to bubble up if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
