rdblue commented on a change in pull request #3148:
URL: https://github.com/apache/iceberg/pull/3148#discussion_r720860330
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/ArrowReader.java
##########
@@ -308,7 +307,11 @@ public boolean hasNext() {
@Override
public ColumnarBatch next() {
- return current;
+ if (hasNext()) {
+ return currentIterator.next();
Review comment:
I think this is good, and I agree with the call to `hasNext()`. We
shouldn't rely on the underlying iterator for correct behavior (throwing
`NoSuchElementException`) because iterators are actually hard to get right.
Plus, this ensures that `hasNext()` doesn't advance the iterator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
