rdblue commented on a change in pull request #3039:
URL: https://github.com/apache/iceberg/pull/3039#discussion_r720861515
##########
File path: core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java
##########
@@ -65,12 +65,18 @@ public static boolean ancestorOf(Table table, long
snapshotId, long ancestorSnap
}
/**
- * Traverses the history of the table's current snapshot and finds the
oldest Snapshot.
- * @return null if there is no current snapshot in the table, else the
oldest Snapshot.
+ * Traverses the history of the table's current snapshot
+ * and finds the oldest Snapshot after or equal to the timestamp in
milliseconds.
+ * @return null if there is no current snapshot in the table,
+ * else the oldest Snapshot after or equal to the timestamp in milliseconds.
*/
- public static Snapshot oldestSnapshot(Table table) {
+ public static Snapshot oldestSnapshot(Table table, long timestampMillis) {
Review comment:
To be clear, I'm asking for 2 things here:
1. This should leave `oldestSnapshot` unchanged and should create a new
method, `oldestAncestorAfter`.
2. This needs to avoid the `NullPointerException` that will be thrown when
`table.snapshot(current.parentId())` returns `null` because the parent snapshot
is no longer in table metadata. You can simulate this case by creating a couple
snapshots and then expiring the first and asking for a timestamp older than the
earliest snapshot in the table, but after the snapshot you expired.
Since there is some confusion here, I think this method also warrants some
test cases to validate its behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
