nastra commented on a change in pull request #3215:
URL: https://github.com/apache/iceberg/pull/3215#discussion_r721367134
##########
File path: core/src/main/java/org/apache/iceberg/util/Tasks.java
##########
@@ -213,7 +214,7 @@ public boolean run(Task<I, RuntimeException> task) {
try {
runTaskWithRetry(task, item);
succeeded.add(item);
-
+ threw = false;
Review comment:
I believe we need to set `threw = false` here instead of in L230, as
otherwise `threw` will always be `false` when it reaches the check in
https://github.com/apache/iceberg/pull/3215/files#diff-e075c62463ddc17c45f8821ee302c98b4ef0c74c304d27f5e82d08470594bce6R271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
