chenjunjiedada commented on a change in pull request #2841: URL: https://github.com/apache/iceberg/pull/2841#discussion_r721419052
########## File path: core/src/main/java/org/apache/iceberg/actions/RewriteDeleteStrategy.java ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import java.util.Map; +import java.util.Set; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.Table; + +public interface RewriteDeleteStrategy { + + /** + * Returns the name of this rewrite deletes strategy + */ + String name(); + + /** + * Returns the table being modified by this rewrite strategy + */ + Table table(); + + /** + * Returns a set of options which this rewrite strategy can use. This is an allowed-list and any options not + * specified here will be rejected at runtime. + */ + Set<String> validOptions(); + + /** + * Sets options to be used with this strategy + */ + RewriteDeleteStrategy options(Map<String, String> options); + + /** + * Select the delete files to rewrite. + * + * @return iterable of original delete file to be replaced. + */ + Iterable<DeleteFile> selectDeleteFiles(); + + /** + * Define how to rewrite the deletes. + * + * @param deleteFilesToRewrite a group of files to be rewritten together + * @return iterable of delete files used to replace the original delete files. + */ + Set<DeleteFile> rewriteDeleteFiles(Set<DeleteFile> deleteFilesToRewrite); + + /** + * Groups file scans into lists which will be processed in a single executable unit. Each group will end up being + * committed as an independent set of changes. This creates the jobs which will eventually be run as by the underlying + * Action. + * + * @param deleteFiles iterable of DeleteFile to be rewritten + * @return iterable of lists of FileScanTasks which will be processed together + */ + Iterable<Set<DeleteFile>> planDeleteFileGroups(Iterable<DeleteFile> deleteFiles); Review comment: Updated to `Iterable`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
