ggershinsky commented on a change in pull request #3053:
URL: https://github.com/apache/iceberg/pull/3053#discussion_r722179525
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java
##########
@@ -96,14 +109,24 @@
this.model = (ParquetValueWriter<T>) createWriterFunc.apply(parquetSchema);
this.metricsConfig = metricsConfig;
this.columnIndexTruncateLength = conf.getInt(COLUMN_INDEX_TRUNCATE_LENGTH,
DEFAULT_COLUMN_INDEX_TRUNCATE_LENGTH);
+ this.rowGroupOrdinal = 0;
try {
this.writer = new ParquetFileWriter(ParquetIO.file(output, conf),
parquetSchema,
- writeMode, rowGroupSize, 0);
+ writeMode, rowGroupSize, 0, columnIndexTruncateLength,
+ // TODO this value is used in current Iceberg. Get from conf instead?
+ ParquetProperties.DEFAULT_STATISTICS_TRUNCATE_LENGTH,
+ // TODO this value is used in current Iceberg. Get from conf instead?
Review comment:
Sounds good, I'll check if they currently can be set by users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
