RussellSpitzer commented on a change in pull request #3059:
URL: https://github.com/apache/iceberg/pull/3059#discussion_r722742747
##########
File path: core/src/test/java/org/apache/iceberg/TestPartitionSpecInfo.java
##########
@@ -65,11 +65,22 @@ public void cleanupTables() {
TestTables.clearTables();
}
+ @Test
+ public void testSpecIsUnpartitionedForVoidTranforms() {
Review comment:
For future reference
```
So in the future you can invoke the V1 Table drop partition columns via
either the Iceberg or Spark3 API. In both cases V1 tables is the default (at
least at the moment)
// Spark 3 Example
https://github.com/apache/iceberg/blob/master/spark3-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAlterTablePartitionFields.java#L195-L213
// V1 Spec Example
https://github.com/apache/iceberg/blob/master/core/src/test/java/org/apache/iceberg/TestPartitioning.java#L63
I think it's probably fine to have the test you have so far unless you want
to add one to TestPartitioning
TestAlterTablePartitionFields.java
<https://github.com/apache/iceberg|apache/iceberg>apache/iceberg | Added by
GitHub
TestPartitioning.java
<https://github.com/apache/iceberg|apache/iceberg>apache/iceberg | Added by
GitHub
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
