dimas-b commented on a change in pull request #3230:
URL: https://github.com/apache/iceberg/pull/3230#discussion_r723368567
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -384,8 +384,9 @@ public boolean dropNamespace(String[] namespace) throws
NoSuchNamespaceException
@Override
public final void initialize(String name, CaseInsensitiveStringMap options) {
- this.cacheEnabled =
Boolean.parseBoolean(options.getOrDefault("cache-enabled", "true"));
Catalog catalog = buildIcebergCatalog(name, options);
+ this.cacheEnabled =
Boolean.parseBoolean(options.getOrDefault("cache-enabled",
+ Boolean.toString(catalog.cachingEnabled())));
Review comment:
Fair enough. In this case how about naming the new method like
`catalog.cachingEnabledDefault()` for the sake of clarity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
