jackye1995 commented on a change in pull request #3237:
URL: https://github.com/apache/iceberg/pull/3237#discussion_r723864048
##########
File path: settings.gradle
##########
@@ -54,22 +50,38 @@ project(':orc').name = 'iceberg-orc'
project(':arrow').name = 'iceberg-arrow'
project(':parquet').name = 'iceberg-parquet'
project(':bundled-guava').name = 'iceberg-bundled-guava'
-project(':spark').name = 'iceberg-spark'
-project(':spark3').name = 'iceberg-spark3'
-project(':spark3-extensions').name = 'iceberg-spark3-extensions'
-project(':spark3-runtime').name = 'iceberg-spark3-runtime'
project(':pig').name = 'iceberg-pig'
project(':hive-metastore').name = 'iceberg-hive-metastore'
project(':nessie').name = 'iceberg-nessie'
+// spark
+include 'spark-common'
+include 'spark'
+include 'spark-extensions'
+include 'spark-runtime'
+
+var SparkSrcVersion = System.getProperty("sparkSrc") != null ?
System.getProperty("sparkSrc") : '3_0'
+
+if (SparkSrcVersion == '2_4' && JavaVersion.current() !=
JavaVersion.VERSION_1_8) {
+ throw new Exception("Expected java8 to build Spark 2.4, but got
${SparkSrcVersion}")
+}
+
+project(':spark-common').name = 'iceberg-spark-common'
Review comment:
I renamed this to common to make `spark` the main directory containing
all versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
