pvary commented on pull request #2935: URL: https://github.com/apache/iceberg/pull/2935#issuecomment-937992096
> btw, I also feel we don't need to move those GenericOrcReader(s) and GenericOrcWriter(s) in this adding delete writer PR in case of making more conflicts when cherry-pick in into people's own repo. ORC java needs to access GenericOrcReader, and `iceberg-data` already depends on `iceberg-orc`, `iceberg-parquet`. To solve this problem I have to move the classes. The added benefit is that the layout is the same as for the Parquet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
