myandpr commented on a change in pull request #3213:
URL: https://github.com/apache/iceberg/pull/3213#discussion_r725185079
##########
File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java
##########
@@ -79,10 +80,11 @@ public void accept(String file) {
private TableMetadata base;
private long expireOlderThan;
private int minNumSnapshots;
+ private ExpireSnapshotResult expireSnapshotResult;
private Consumer<String> deleteFunc = defaultDelete;
private ExecutorService deleteExecutorService =
DEFAULT_DELETE_EXECUTOR_SERVICE;
- RemoveSnapshots(TableOperations ops) {
+ public RemoveSnapshots(TableOperations ops) {
Review comment:
Hi @rdblue , I have separated this PR into `Flink: auto compact small
files
` PR https://github.com/apache/iceberg/pull/3213 and `[Iceberg] Flink:auto
delete expired snapshots` PR https://github.com/apache/iceberg/pull/3255
You can review and discuss the PR in
https://github.com/apache/iceberg/pull/3255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
