rdblue commented on a change in pull request #3230:
URL: https://github.com/apache/iceberg/pull/3230#discussion_r725316672



##########
File path: api/src/main/java/org/apache/iceberg/catalog/Catalog.java
##########
@@ -338,6 +338,15 @@ default TableBuilder buildTable(TableIdentifier 
identifier, Schema schema) {
   default void initialize(String name, Map<String, String> properties) {
   }
 
+  /**
+   * Determines the default caching behavior for the catalog if 
"cache-enabled" is not set.
+   *
+   * @return The default caching behavior for this given catalog if 
"cache-enabled" is not set.
+   */
+  default boolean cachingEnabled() {
+    return true;

Review comment:
       Overall, I think this is working around something that should simply be 
fixed. We should change the caching behavior and expire tables more quickly so 
that we don't have a user issue for some catalogs but not others. I don't think 
that we should move forward with this PR; instead we should fix the behavior 
problem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to