rdblue commented on a change in pull request #3132:
URL: https://github.com/apache/iceberg/pull/3132#discussion_r725395015
##########
File path:
spark2/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java
##########
@@ -83,19 +83,21 @@ public DataSourceReader createReader(StructType readSchema,
DataSourceOptions op
"Save mode %s is not supported", mode);
Configuration conf = new Configuration(lazyBaseConf());
Table table = getTableAndResolveHadoopConfiguration(options, conf);
- boolean handleTimestampWithoutZone =
- SparkUtil.canHandleTimestampWithoutZone(options.asMap(),
lazySparkSession().conf());
- Preconditions.checkArgument(handleTimestampWithoutZone ||
!SparkUtil.hasTimestampWithoutZone(table.schema()),
- SparkUtil.TIMESTAMP_WITHOUT_TIMEZONE_ERROR);
+ SparkWriteConf writeConf = new SparkWriteConf(lazySparkSession(), table,
options.asMap());
Review comment:
`options.asMap()` returns the lower case map. Should we ensure that
we're using case insensitive lookup in that map for Spark options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
