rdblue commented on a change in pull request #3258:
URL: https://github.com/apache/iceberg/pull/3258#discussion_r725673009
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java
##########
@@ -282,9 +281,14 @@ private void commitDeltaTxn(NavigableMap<Long,
WriteResult> pendingResults, Stri
// txn2, the equality-delete files of txn2 are required to be applied
to data files from txn1. Committing the
// merged one will lead to the incorrect delete semantic.
Review comment:
I think it's okay either way. This comment is saying that the inserts
from one checkpoint are affected by delete files in the next checkpoint, so we
have to commit them separately rather than as a single transaction. The `txn`
numbers were already generic, since the map may have more than 2 entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
