openinx commented on a change in pull request #3250:
URL: https://github.com/apache/iceberg/pull/3250#discussion_r725762318
##########
File path: data/src/main/java/org/apache/iceberg/data/DeleteFilter.java
##########
@@ -227,6 +229,15 @@ protected boolean shouldKeep(T item) {
return builder.build();
case ORC:
+ ORC.ReadBuilder orcBuilder = ORC.read(input)
+ .project(deleteSchema)
Review comment:
Q: why the ORC reader don't enable the reuse container switch ? Is
there any intentional purpose that I did not get before ? I see the Spark ORC
Reader also don't enable the switch:
https://github.com/apache/iceberg/blob/7cf96f096edeceac13916676c273954fdd435513/spark/src/main/java/org/apache/iceberg/spark/source/RowDataReader.java#L160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
