Flyangz opened a new pull request #3271: URL: https://github.com/apache/iceberg/pull/3271
This pr is for #2082 , so we first thank @zhangjun0x01 for his contribution. Below are some explanations about the implementation of `listPartitions(ObjectPath tablePath, CatalogPartitionSpec partitionSpec)`: It first finds the latest matching partition spec by the input `partitionSpec`. Then it constructs a filter and finds all matching partitions based on this filter. Finally, the partitions would be sorted and return. I do not know if we need to sort the result. If needed, then we should add sorting in [`listPartitions(ObjectPath tablePath)`](https://github.com/apache/iceberg/blob/6ca31fc2933e7533cc0f9bad9fcbc81c16c13a57/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java#L659) too, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
