pvary commented on a change in pull request #2935:
URL: https://github.com/apache/iceberg/pull/2935#discussion_r726133191
##########
File path: orc/src/main/java/org/apache/iceberg/data/orc/GenericOrcWriters.java
##########
@@ -531,6 +543,34 @@ public void nonNullWrite(int rowId, Map<K, V> map,
ColumnVector output) {
}
}
+ private static class DeleteWriter implements
OrcRowWriter<PositionDelete<Record>> {
+ private final OrcRowWriter<Record> rowWriter;
+ private final Schema deleteSchema;
+ private final GenericRecord record;
+
+ DeleteWriter(Schema deleteSchema, OrcRowWriter rowWriter) {
+ this.deleteSchema = deleteSchema;
Review comment:
The final solution is very similar to the Parquet implementation. See:
#3250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
