rdblue commented on a change in pull request #3252:
URL: https://github.com/apache/iceberg/pull/3252#discussion_r726519097
##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -95,6 +95,10 @@ public HiveCatalog(Configuration conf) {
@Override
public void initialize(String inputName, Map<String, String> properties) {
this.name = inputName;
+ if (this.conf == null){
+ LOG.warn("No configuration was set, using a default configuration");
Review comment:
I think we should call out that this is a Hadoop `Configuration`.
Otherwise, this warning is potentially misleading.
How about changing this to "No Hadoop Configuration was set, using the
default environment Configuration"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
