aokolnychyi commented on a change in pull request #3256:
URL: https://github.com/apache/iceberg/pull/3256#discussion_r726543327
##########
File path: settings.gradle
##########
@@ -55,21 +52,44 @@ project(':arrow').name = 'iceberg-arrow'
project(':parquet').name = 'iceberg-parquet'
project(':bundled-guava').name = 'iceberg-bundled-guava'
project(':spark').name = 'iceberg-spark'
-project(':spark3').name = 'iceberg-spark3'
-project(':spark3-extensions').name = 'iceberg-spark3-extensions'
-project(':spark3-runtime').name = 'iceberg-spark3-runtime'
project(':pig').name = 'iceberg-pig'
project(':hive-metastore').name = 'iceberg-hive-metastore'
project(':nessie').name = 'iceberg-nessie'
+String defaultSparkVersions = "2.4,3.0"
+List<String> knownSparkVersions = ["2.4", "3.0"]
+List<String> sparkVersions = (System.getProperty("sparkVersions") != null ?
System.getProperty("sparkVersions") : defaultSparkVersions).split(",")
+
+if (!knownSparkVersions.containsAll(sparkVersions)) {
+ throw new GradleException("Found unsupported Spark versions: " +
(sparkVersions - knownSparkVersions))
+}
+
+if (sparkVersions.contains("3.0")) {
+ include ':iceberg-spark:spark3'
+ include ':iceberg-spark:spark3-extensions'
+ include ':iceberg-spark:spark3-runtime'
+ project(':iceberg-spark:spark3').projectDir = file('spark/v3.0/spark3')
+ project(':iceberg-spark:spark3').name = 'iceberg-spark3'
+ project(':iceberg-spark:spark3-extensions').projectDir =
file('spark/v3.0/spark3-extensions')
+ project(':iceberg-spark:spark3-extensions').name =
'iceberg-spark3-extensions'
+ project(':iceberg-spark:spark3-runtime').projectDir =
file('spark/v3.0/spark3-runtime')
+ project(':iceberg-spark:spark3-runtime').name = 'iceberg-spark3-runtime'
+}
+
if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
Review comment:
Do we need to throw an exception if someone asks for 2.4 and has JDK 11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
