omarsmak commented on a change in pull request #3162:
URL: https://github.com/apache/iceberg/pull/3162#discussion_r726794680
##########
File path: core/src/test/java/org/apache/iceberg/TestCatalogUtil.java
##########
@@ -159,6 +159,18 @@ public void loadCustomFileIO_badClass() {
() -> CatalogUtil.loadFileIO(TestFileIONotImpl.class.getName(),
Maps.newHashMap(), null));
}
+ @Test
+ public void buildCustomCatalog_withTypeSet() {
+ Map<String, String> options = new HashMap<>();
+ options.put(CatalogProperties.CATALOG_IMPL, "CustomCatalog");
+ options.put(CatalogUtil.ICEBERG_CATALOG_TYPE, "hive");
+ Configuration hadoopConf = new Configuration();
+ String name = "custom";
+
+ AssertHelpers.assertThrows("Should complain about both configs being set",
IllegalArgumentException.class,
Review comment:
This actually changes the behavior for Spark and Hive. Flink I will add
it in a follow up PR since the changes are in different places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
