szlta commented on a change in pull request #3248:
URL: https://github.com/apache/iceberg/pull/3248#discussion_r726977756
##########
File path: data/src/main/java/org/apache/iceberg/data/orc/GenericOrcWriters.java
##########
@@ -531,6 +534,46 @@ public void nonNullWrite(int rowId, Map<K, V> map,
ColumnVector output) {
}
}
+ public abstract static class StructWriter<S> implements OrcValueWriter<S> {
+ private final List<OrcValueWriter<?>> writers;
+
+ protected StructWriter(List<OrcValueWriter<?>> writers) {
+ this.writers = writers;
+ }
+
+ public List<OrcValueWriter<?>> writers() {
Review comment:
I think we should leave that as it will come handy for
https://github.com/apache/iceberg/pull/3250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
