openinx commented on a change in pull request #3258:
URL: https://github.com/apache/iceberg/pull/3258#discussion_r727125354
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java
##########
@@ -282,9 +281,14 @@ private void commitDeltaTxn(NavigableMap<Long,
WriteResult> pendingResults, Stri
// txn2, the equality-delete files of txn2 are required to be applied
to data files from txn1. Committing the
// merged one will lead to the incorrect delete semantic.
WriteResult result = e.getValue();
- RowDelta rowDelta = table.newRowDelta()
-
.validateDataFilesExist(ImmutableList.copyOf(result.referencedDataFiles()))
- .validateDeletedFiles();
+
+ // row delta validations are not needed for streaming changes that
write equality deletes. Equality deletes
Review comment:
Nit: row delta -> Row delta.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
