nssalian commented on a change in pull request #3275:
URL: https://github.com/apache/iceberg/pull/3275#discussion_r727397358
##########
File path: core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java
##########
@@ -27,48 +31,91 @@
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.relocated.com.google.common.base.Splitter;
import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
+import org.apache.iceberg.util.JsonUtil;
final class JdbcUtil {
+ // Catalog Table
protected static final String CATALOG_TABLE_NAME = "iceberg_tables";
protected static final String CATALOG_NAME = "catalog_name";
protected static final String TABLE_NAMESPACE = "table_namespace";
protected static final String TABLE_NAME = "table_name";
protected static final String METADATA_LOCATION = "metadata_location";
protected static final String PREVIOUS_METADATA_LOCATION =
"previous_metadata_location";
+
public static final String DO_COMMIT_SQL = "UPDATE " + CATALOG_TABLE_NAME +
- " SET " + METADATA_LOCATION + " = ? , " + PREVIOUS_METADATA_LOCATION + "
= ? " +
- " WHERE " + CATALOG_NAME + " = ? AND " +
- TABLE_NAMESPACE + " = ? AND " +
- TABLE_NAME + " = ? AND " +
- METADATA_LOCATION + " = ?";
+ " SET " + METADATA_LOCATION + " = ? , " + PREVIOUS_METADATA_LOCATION
+ " = ? " +
Review comment:
The checkStyles didn't catch this though. Let me look again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
