ConeyLiu commented on a change in pull request #3249:
URL: https://github.com/apache/iceberg/pull/3249#discussion_r727740396
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java
##########
@@ -36,6 +36,7 @@
private final Dictionary dictionary;
private final NullabilityHolder nullabilityHolder;
private final Type icebergType;
+ private final Type originalIcebergType;
Review comment:
`icebergType` indicates the corresponding iceberg type of the
`FieldVector`， `originalIcebergType` indicates what the real type we will read
from the `FieldVector`. For example, the parquet int backed decimal, the
`icebergType` should be integer, `originalIcebergType` is decimal.
I intend to only keep the `originalIcebergType`, but listening to your ideas.
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -171,6 +177,8 @@ public VectorHolder read(VectorHolder reuse, int
numValsToRead) {
vectorizedColumnIterator.timestampMillisBatchReader().nextBatch(vec, typeWidth,
nullabilityHolder);
break;
case UUID:
+ case FIXED_WIDTH_BINARY:
+ case FIXED_LENGTH_DECIMAL:
Review comment:
Here, combined the `FIXED_WIDTH_BINARY` to use
`fixedSizeBinaryBatchReader` instead of `fixedWidthTypeBinaryBatchReader`.
`fixedWidthTypeBinaryBatchReader` uses `VarBinaryVector`, it should be use
`FixedSizeBinaryVector`. Please correct me if I understand wrong @nastra
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -171,6 +177,8 @@ public VectorHolder read(VectorHolder reuse, int
numValsToRead) {
vectorizedColumnIterator.timestampMillisBatchReader().nextBatch(vec, typeWidth,
nullabilityHolder);
break;
case UUID:
+ case FIXED_WIDTH_BINARY:
+ case FIXED_LENGTH_DECIMAL:
Review comment:
Here, combined the `FIXED_WIDTH_BINARY` to use
`fixedSizeBinaryBatchReader` instead of `fixedWidthTypeBinaryBatchReader`.
`fixedWidthTypeBinaryBatchReader` uses `VarBinaryVector`, it should be use
`FixedSizeBinaryVector`. Please correct me if I am wrong @nastra
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -171,6 +177,8 @@ public VectorHolder read(VectorHolder reuse, int
numValsToRead) {
vectorizedColumnIterator.timestampMillisBatchReader().nextBatch(vec, typeWidth,
nullabilityHolder);
break;
case UUID:
+ case FIXED_WIDTH_BINARY:
+ case FIXED_LENGTH_DECIMAL:
Review comment:
Here, combined the `FIXED_WIDTH_BINARY` to use
`fixedSizeBinaryBatchReader` instead of `fixedWidthTypeBinaryBatchReader`.
`fixedWidthTypeBinaryBatchReader` uses `VarBinaryVector`, it should use
`FixedSizeBinaryVector`. Please correct me if I am wrong @nastra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
