jackye1995 commented on a change in pull request #3279:
URL: https://github.com/apache/iceberg/pull/3279#discussion_r727374563
##########
File path: site/docs/spark-writes.md
##########
@@ -170,7 +170,17 @@ DELETE FROM prod.db.table
WHERE ts >= '2020-05-01 00:00:00' and ts < '2020-06-01 00:00:00'
```
-If the delte filter matches entire partitions of the table, Iceberg will
perform a metadata-only delete. If the filter matches individual rows of a
table, then Iceberg will rewrite only the affected data files.
+If delete filter matches entire partitions of the table, Iceberg will perform
a metadata-only delete. If the filter matches individual rows of a table, then
Iceberg will rewrite only the affected data files.
+
+Delete queries can also work on subquery as shown below
+
+```sql
Review comment:
I think we don't need to have a separated section, these can just be
examples added to L170.
##########
File path: site/docs/spark-writes.md
##########
@@ -184,6 +194,18 @@ SET c1 = 'update_c1', c2 = 'update_c2'
WHERE ts >= '2020-05-01 00:00:00' and ts < '2020-06-01 00:00:00'
```
+Update queries can also work on subquery as shown below
Review comment:
Similarly, we can just add these examples to L182
##########
File path: site/docs/spark-writes.md
##########
@@ -170,7 +170,17 @@ DELETE FROM prod.db.table
WHERE ts >= '2020-05-01 00:00:00' and ts < '2020-06-01 00:00:00'
```
-If the delte filter matches entire partitions of the table, Iceberg will
perform a metadata-only delete. If the filter matches individual rows of a
table, then Iceberg will rewrite only the affected data files.
+If delete filter matches entire partitions of the table, Iceberg will perform
a metadata-only delete. If the filter matches individual rows of a table, then
Iceberg will rewrite only the affected data files.
Review comment:
nit: the delete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
