miR172 commented on pull request #3177: URL: https://github.com/apache/iceberg/pull/3177#issuecomment-942606395
@nssalian is working on splitting sql tables #3274. Followed that change I would address the following based on the code here: 1. Create an interface for JdbcCatalog to use a database. This allows implementations to use different SQL dialects and advanced jdbc-driver wrapper (like Jooq, or Spanner). 2. The existing plain text queries will be packed into a default impl because it requires no extra dependency. I've created #3291 @jackye1995 @rdblue Please comment. If this sounds reasonable I'll open this PR (make it non-draft) with another code change. All jooq and S3 code will be removed out. After that, we can work on adding createNamespace to the default impl. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
